Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different asset name for Ubuntu on arm64 binary assets #155

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

remyroy
Copy link
Member

@remyroy remyroy commented Sep 16, 2024

Fixes #152

Changes

  • Rework the build workflow to create assets with a different name on Ubuntu arm64 compared to Ubuntu amd64. See a recent build run to notice that they are currently both named amd64.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

This will be tested during the next test release which should be in a few days.

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@valefar-on-discord valefar-on-discord merged commit 6ce2d09 into eth-educators:main Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ci-build workflow for arm64 Ubuntu binaries.
2 participants