Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows 11 ARM64 to workflows #132

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yorickdowne
Copy link

Changes

Add Windows 11 ARM64 to CI and build workflow

Types of changes

What types of changes does your code introduce?

  • Build-related changes

Testing

Requires testing

  • Yes
  • No

@yorickdowne
Copy link
Author

yorickdowne commented Sep 2, 2024

Keep this in draft until actions/setup-python#931 has been confirmed resolved

@yorickdowne yorickdowne added the run-tests Request tests to run on the CI label Sep 2, 2024
@remyroy
Copy link
Member

remyroy commented Sep 2, 2024

I think we might have to bootstrap installing Microsoft C++ Build Tools ourselves on that Windows ARM runner image or use custom images both of which are likely to add some complexity.

@yorickdowne
Copy link
Author

yorickdowne commented Sep 2, 2024

I'm not convinced we should do this ourselves. We don't have to on Windows amd64 or any other image. I expect images to be ready for pip install wheel after setup-python. Let's see what Github has to say, surely they can fix this in either the image or the action.

Opened actions/partner-runner-images#19 for it

@yorickdowne
Copy link
Author

A new Windows arm64 image is being built, which will include the dev tools. Give it a week or two.

@yorickdowne yorickdowne added run-tests Request tests to run on the CI and removed run-tests Request tests to run on the CI labels Sep 19, 2024
@yorickdowne
Copy link
Author

Pinged the arm team on this. “Soon” in August was clearly optimistic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-tests Request tests to run on the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants