Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systems with firecrest scheduler #146

Merged
merged 8 commits into from
Jan 23, 2024
Merged

Conversation

ekouts
Copy link
Collaborator

@ekouts ekouts commented Jan 9, 2024

It needs reframe-hpc/reframe#3093, otherwise we have to run it by setting the env var RFM_RESOLVE_MODULE_CONFLICTS=false.

Autodetection needs reframe-hpc/reframe#3094 to work.

relates to https://jira.cscs.ch/browse/VCUE-151

@ekouts ekouts self-assigned this Jan 9, 2024
@ekouts ekouts requested a review from teojgo January 12, 2024 16:34
@ekouts ekouts marked this pull request as ready for review January 12, 2024 16:34
@ekouts ekouts requested a review from jgphpc January 12, 2024 16:34
Copy link
Collaborator

@jgphpc jgphpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm to me
tested on daint

  • we would probably need some doc + list of differences with the legacy (not f7t) way
  • and maybe a dedicated ci pipeline ?

config/cscs.py Outdated Show resolved Hide resolved
# Select the firecrest configuration files that support the firecrest scheduler
RFM_FIRECREST=1

# The `RFM_RESOLVE_MODULE_CONFLICTS` var is not necessary for version >=4.6. Bugfix https://github.com/reframe-hpc/reframe/pull/3093
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ~/reframe.git/bin/reframe -V # 4.6.0-dev.0+35fce1eb
unset RFM_RESOLVE_MODULE_CONFLICTS

~/reframe.git/bin/reframe -C ~/cscs-reframe-tests.git/config/cscs.py -c checks/prgenv/mpi.py -l --system daint:mc

fails with:

ERROR: failed to initialize runtime: could not find a sane TMod installation

No issue if RFM_RESOLVE_MODULE_CONFLICTS is set.

@@ -1,4 +1,4 @@
# Copyright 2016-2023 Swiss National Supercomputing Centre (CSCS/ETH Zurich)
# Copyright 2016 Swiss National Supercomputing Centre (CSCS/ETH Zurich)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024 because it's a new file ?

@ekouts ekouts merged commit 519d6fb into eth-cscs:alps Jan 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants