Add Matrix::subPipeline{,Const}
#898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cscs-ci run |
msimberg
force-pushed
the
matrix-sub-pipeline
branch
from
3b818d8
to
f2fd48b
Compare
|
cscs-ci run |
msimberg
changed the title
Matrix::subPipeline(Const)Matrix::subPipeline{,Const}
rasolca
approved these changes
Jun 22, 2023
albestro
reviewed
Jul 4, 2023
There was a problem hiding this comment.
Nice job!
About naming, it is a bit difficult to give better suggestions. An issue is that we are acting on a Matrix, which is a set of Tiles each one with its own pipeline. And with mat.subPipeline() we are actually getting a sub-pipeline for each tile in the matrix (or for a subset of them in the future). Plural? But it is not given that a matrix have multiple tiles.
Probably I would start thinking in terms of scopes (along the lines of what you suggested with "nested") mat.createNestedScope/mat.createNestedConstScope?
… read-after-read optimization
|
cscs-ci run |
msimberg
force-pushed
the
matrix-sub-pipeline
branch
from
a379c22
to
5adba0b
Compare
|
cscs-ci run |
This was referenced Jul 5, 2023
albestro
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #868.
This adds the naive, non-optimized, version of getting a
Matrixfrom anotherMatrixwith tiles in a sub-pipeline, i.e. tile accesses from the sub-pipelinedMatrixare sequenced after all previous tile accesses to the originalMatrixand before all later tile accesses to the originalMatrix.The missing optimization is merging of read-only accesses between the parent
Matrixand the sub-pipelinedMatrix. Creating a sub-pipelinedMatrixcurrently implies one "hidden" read-write access to the parentMatrix. Releasing the sub-pipelinedMatrixreleases all subsequent accesses from the parentMatrix.In the end this naive version required very few changes to
Matrix, and did not require a separate type. I think this is a good thing. One of the open questions from this is ifMatrixshould have adonemethod? As far as I can tellRetiledMatrixshould be possible to refactor intoMatrixin exactly the same way and that would also introducedoneintoMatrix.This can already now be used in conjunction with
Views to access a sub-matrix with sub-pipelines. To have sub-matrices with sub-pipelines we first need to updateDistribution.Are the names
subPipelineandsubPipelineConstunderstandable? I'd like to avoidsubMatrixPipelinesince this doesn't yet handle sub-matrices. "nest" is a word that I'm thinking could fit well to the "sub-pipeline" aspect of the access but not sure yet.nest/nestRead/nestConst/nested*. In order to allow optimizing access to only a sub-matrix in the future I'd imagine the function signature would be expanded in the future to look like:subPipeline/nested/whatever(SubTileMatrixSpec/SubElementMatrixSpec const& = full_matrix)and then it'd be nice if the name would cleanly cover the future use cases as well but this future version could of course simply get a new name. Suggestions welcome.