Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that SingleThreadedBlasScope is created and destroyed on the same std::thread #889

Merged

Conversation

msimberg
Copy link
Collaborator

@msimberg msimberg commented May 30, 2023

Based on #860 (comment).

@msimberg msimberg self-assigned this May 30, 2023
@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg msimberg changed the title Check that SingleThreadedBlasScope is created and destroyed on the same std::thread Check that SingleThreadedBlasScope is created and destroyed on the same std::thread May 30, 2023
@msimberg msimberg force-pushed the check-single-threaded-blas-same-thread branch from cf2d8df to a84ae60 Compare May 30, 2023 13:05
@msimberg
Copy link
Collaborator Author

cscs-ci run

1 similar comment
@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg msimberg marked this pull request as ready for review May 31, 2023 09:11
src/common/single_threaded_blas.cpp Outdated Show resolved Hide resolved
@msimberg msimberg force-pushed the check-single-threaded-blas-same-thread branch from a84ae60 to 9f546fc Compare May 31, 2023 09:47
@msimberg
Copy link
Collaborator Author

cscs-ci run

1 similar comment
@rasolca
Copy link
Collaborator

rasolca commented Jun 1, 2023

cscs-ci run

@rasolca
Copy link
Collaborator

rasolca commented Jun 1, 2023

@msimberg FYI:

test 43
      Start 43: test_bt_band_to_tridiag
43: Test command: /DLA-Future-build/test/unit/eigensolver/test_bt_band_to_tridiag
43: Test timeout computed to be: 10000000
43: Running main() from gtest_mpipika_main.cpp
43: [==========] Running 16 tests from 4 test suites.
43: [----------] Global test environment set-up.
43: [----------] 4 tests from BacktransformationBandToTridiagTestMC/0, where TypeParam = float
43: [ RUN      ] BacktransformationBandToTridiagTestMC/0.CorrectnessLocal
43: [ERROR] /DLA-Future/src/common/single_threaded_blas.cpp:41 : dlaf::common::internal::SingleThreadedBlasScope::~SingleThreadedBlasScope()
43: calling_thread == current_thread
43: 140727143212608
43: 140727134819904
43: 
43: terminate called without an active exception
13/27 Test #43: test_bt_band_to_tridiag ...........***Failed    0.38 sec

@msimberg msimberg marked this pull request as draft June 1, 2023 11:44
@msimberg
Copy link
Collaborator Author

msimberg commented Jun 2, 2023

cscs-ci run

@msimberg msimberg marked this pull request as ready for review June 2, 2023 07:21
@msimberg
Copy link
Collaborator Author

msimberg commented Jun 2, 2023

Yielding was happening in the test itself of bt_band_to_tridiag (not the algorithm implementation) and I've fixed that in 6daae56.

@msimberg
Copy link
Collaborator Author

msimberg commented Jun 5, 2023

cscs-ci run

@msimberg
Copy link
Collaborator Author

msimberg commented Jun 5, 2023

I had to fix one more yielding while holding SingleThreadedBlasScope in test_tridiag_solver_rot. Note that the test was hanging rather than directly reporting the failure and I'm not quite sure why that's the case. The reason for the failure was the same though. Locally it failed immediately whereas in CI it hung.

@msimberg msimberg requested review from albestro and RMeli June 5, 2023 10:57
@rasolca rasolca merged commit 0bd72f8 into eth-cscs:master Jun 5, 2023
github-actions bot pushed a commit that referenced this pull request Jun 5, 2023
@msimberg msimberg deleted the check-single-threaded-blas-same-thread branch June 5, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants