Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need of the distributed row permutation in the tridiagonal solver. #831

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

rasolca
Copy link
Collaborator

@rasolca rasolca commented Apr 11, 2023

The distributed row permutation is not needed as the matrix can be setup in the correct order from the beginning.

Benchmarks will follow.
Depends on #819.

@rasolca
Copy link
Collaborator Author

rasolca commented Apr 11, 2023

cscs-ci run

@rasolca rasolca marked this pull request as draft April 11, 2023 18:04
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Merging #831 (086c1a9) into master (2a2641a) will increase coverage by 1.66%.
The diff coverage is 99.08%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
+ Coverage   93.38%   95.04%   +1.66%     
==========================================
  Files         132      118      -14     
  Lines        8041     7109     -932     
  Branches     1027      956      -71     
==========================================
- Hits         7509     6757     -752     
+ Misses        368      212     -156     
+ Partials      164      140      -24     
Impacted Files Coverage Δ
src/eigensolver/tridiag_solver/kernels.cpp 99.03% <96.66%> (-0.97%) ⬇️
include/dlaf/eigensolver/tridiag_solver/impl.h 100.00% <100.00%> (ø)
include/dlaf/eigensolver/tridiag_solver/kernels.h 100.00% <100.00%> (ø)
include/dlaf/eigensolver/tridiag_solver/merge.h 100.00% <100.00%> (ø)

... and 33 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rasolca rasolca marked this pull request as ready for review April 12, 2023 10:02
@rasolca
Copy link
Collaborator Author

rasolca commented Apr 12, 2023

cscs-ci run

@rasolca
Copy link
Collaborator Author

rasolca commented Apr 13, 2023

Copy link
Collaborator

@albestro albestro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really able to follow the algorithmic change.

After a quick look, LGTM

@rasolca rasolca merged commit 970dc57 into master Apr 17, 2023
@rasolca rasolca deleted the rasolca/tridiag-3 branch April 17, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants