-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the need of the distributed row permutation in the tridiagonal solver. #831
Conversation
cscs-ci run |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #831 +/- ##
==========================================
+ Coverage 93.38% 95.04% +1.66%
==========================================
Files 132 118 -14
Lines 8041 7109 -932
Branches 1027 956 -71
==========================================
- Hits 7509 6757 -752
+ Misses 368 212 -156
+ Partials 164 140 -24
... and 33 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…in the correct order. (MC OK, GPU can be broken)
06b36b7
to
086c1a9
Compare
cscs-ci run |
Benchmarks: See updated plots on https://confluence.cscs.ch/display/SCISWDEV/2023-03-14+Optimisation+Round+2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really able to follow the algorithmic change.
After a quick look, LGTM
The distributed row permutation is not needed as the matrix can be setup in the correct order from the beginning.
Benchmarks will follow.
Depends on #819.