Testing framework

[austinabell]

This is the testing framework for running ETH tests from https://github.com/ethereum/tests.

To test this, run git submodule update --init to pull test files and then to run only the state test suite run

go test ./tests/state_test.go ./tests/util.go ./tests/init.go ./tests/vm_test_util.go ./tests/state_test_util.go

(You can just run go test ./tests or go test ./... but that will run all of the existing tests and is slow)

Entry point into these tests are as follows:

func TestETHHomestead(t *testing.T) {
	fns, _ := filepath.Glob(filepath.Join(ethGeneralStateDir, "stHomesteadSpecific", "*"))
	runETHTests(t, fns)
}

Where the stHomesteadSpecific file path can be changed to any of the folders within ethereum/tests submodule.

Note: The Byzantium and EIP158 fork tests will be failing currently as it depends on state trie clearing functionality (and possibly some other changes made since the DAO fork) but all other tests should pass.

There is existing logic in the code for handling deleting empty objects in the trie, but it isn't handled exactly how the ethereum protocol expects. This will probably be fixed with the EIP158/161 implementation in ETC that is being completed.

[GregTheGreek]

you can remove the commented out code

[soc1c]

lgtm

[GregTheGreek]

@soc1c HE'S ALIVE

[noot]

TestETHHomestead fails when I run the tests:

--- FAIL: TestETHHomestead (0.01s)
    --- FAIL: TestETHHomestead/contractCreationOOGdontLeaveEmptyContract.json (0.00s)
        --- FAIL: TestETHHomestead/contractCreationOOGdontLeaveEmptyContract.json/Byzantium/0 (0.00s)
            state_test.go:733: Post state root error. Expected: 35df33d2a146ff660bb837914781857715d1b8752371b2f3e0768f29dd484775 have: 11ad11c6c73f16022220dad1de2eb827aa3c04fa651f7a7b15231ed98efab9bc
    --- FAIL: TestETHHomestead/contractCreationOOGdontLeaveEmptyContractViaTransaction.json (0.00s)
        --- FAIL: TestETHHomestead/contractCreationOOGdontLeaveEmptyContractViaTransaction.json/Byzantium/0 (0.00s)
            state_test.go:733: Post state root error. Expected: 86631b9f3536a824efa412c3162885c8bbb1657e315b8dbbda6a24a8ae8ff868 have: bf80ccfd1a7e6bf9f0ab98b938595389fd7240f2206c33bade862e49c19c2248
    --- FAIL: TestETHHomestead/createContractViaContract.json (0.00s)
        --- FAIL: TestETHHomestead/createContractViaContract.json/Byzantium/0 (0.00s)
            state_test.go:733: Post state root error. Expected: 00a243435c3922719d07f434874d20e02a1971ca2bc6d6359bcc18f7e1e766f1 have: 49c4c18bd400d25e0905c026db96e0b4441d2dffe0a62d47d1e9354a4166794d
    --- FAIL: TestETHHomestead/createContractViaContractOOGInitCode.json (0.00s)
        --- FAIL: TestETHHomestead/createContractViaContractOOGInitCode.json/Byzantium/0 (0.00s)
            state_test.go:733: Post state root error. Expected: f079b93388a39a4c343c66a917a044fb0d91de079786366d0c6c3b01bee07e7b have: ef627373222f9f8a0c974af676a99f9a8c62a585e7b8935cec7a26a7029ae6f0
    --- FAIL: TestETHHomestead/createContractViaTransactionCost53000.json (0.00s)
        --- FAIL: TestETHHomestead/createContractViaTransactionCost53000.json/Byzantium/0 (0.00s)
            state_test.go:733: Post state root error. Expected: 01d55964b2d7eb43d050c308c5835cbc9d0d876a35fd855f063ca4fc424c4e28 have: 087b558ee1cfed6f35debfdc37ea5ca5db71243f59fee0d6b9a0f8c5235355e8
FAIL
FAIL	command-line-arguments	6.233s

is this expected behaviour? everything else looks good to me

[soc1c]

@noot yes