Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-push instructions #952

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

kirk-baird
Copy link
Contributor

What I did

There is an issue when processing instructions which are not PUSH that will lead to bad int conversion.

Related issue: #873 also related to PR #935

The issue is almost identical to above but occurs in another location.

How I did it

How to verify it

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation
  • I have added an entry to the changelog

Signed-off-by: Kirk Baird <[email protected]>
Copy link
Member

@iamdefinitelyahuman iamdefinitelyahuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, ser!

@iamdefinitelyahuman iamdefinitelyahuman merged commit 845f91a into eth-brownie:master Feb 8, 2021
@kirk-baird kirk-baird deleted the solidity-push branch February 8, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants