Feat chainid networkid #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Exposed
--chainId->chain_idand--networkId->network_idparameters for ganache-cli to the brownie network config.Forked networks will default to the
chain_idof the origin network (can be overwritten).IMPORTANT:
--chainIdrequires ganache-cli version 6.11.0 or higher. To use this feature, ganache-cli has to be updated.Related issue: #901
How I did it
Added the parameters to the list of accepted network settings.
Fetch
chain_idfrom origin network and set as default when a fork (and no customchain_id) is specified.Accepted types for both values are integers (ganache will ignore anything else). Other types will issue a warning.
How to verify it
Run updated tests.
Checklist