Improved handling of trace queries / exceptions #853
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Do not attempt to query a trace when the node client does not support it.
How I did it
web3.supports_traces
property method. This method callsdebug_traceTransaction
without any arguments and checks the returned error code. If the return code is -32601, the endpoint does not exist. Any other error means the endpoint does exist.TransactionReceipt
methods, check forweb3.supports_traces
prior to attempting to query a trace. IfFalse
, give a more meaningful error than the standard "RPC endpoint does not exist / is not available".How to verify it
Run the tests. I've added some new cases.