Add gas_buffer #739
Merged
Add gas_buffer #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add
gas_bufferto transactions, a multiplier applied toeth_estimateGaswhen determining the gas limit for a transaction.Closes #725
How I did it
gas_bufferis a valid kwarg foraccount.transferor value in a contract call transaction dictionary.main.gas_buffer()may be used to modify the default settinggas_buffermay be included in the configuration settingsYou cannot provide both
gas_bufferandgas_limitat the same time, doing so raises aValueError.How to verify it
Run the tests. I added some new test cases around the behaviour.