-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand call_trace #679
Merged
Merged
Expand call_trace #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdefinitelyahuman
force-pushed
the
feat-subcalls
branch
from
July 12, 2020 20:59
cc18b6d
to
7b9da18
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Expand
TransactionReceipt.call_trace
to include inputs and return values for external calls.Closes #625
How I did it
TransactionReceipt.subcalls
attribute. This is a trace property that records all the subcall info while the trace is expanded. See the updated documentation for more info on how it is structured._ContractMethod.decode_input
method for decoding input arguments.brownie.utils.output.build_tree
. The new approach uses nested dicts and lists. It's far more powerful and better documented than the previous approach. For now I haven't touched other tree diagrams, but in thev2
refactor everything will be refactored to use this method.black
is now a proper brownie dependency, rather than a dev-dependency. I'm using it to handle formatting for inputs and return values, so there isn't any weirdness when displaying lengthy arrays. Forv2
i think some of the home-rolled formatting code in the console can be replaced withblack
.