Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite loop when downloading implementation contract #672

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Fix infinite loop when downloading implementation contract #672

merged 1 commit into from
Jul 8, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

Before downloading an implementation contract, check that it's address is != the address of the proxy contract.

Fixes #669

How to verify it

In the console:

>>> Contract.from_explorer('0x080bf510FCbF18b91105470639e9561022937712')

@iamdefinitelyahuman iamdefinitelyahuman merged commit f6e8265 into master Jul 8, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the fix-etherscan-proxy branch July 8, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinite loop fetching source from etherscan
1 participant
@iamdefinitelyahuman