Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling when using parity #631

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

Improve VirtualMachineException logic to handle reverts from Parity.

How to verify it

Connect to Kovan and do something to trigger a revert.

Copy link
Collaborator

@matnad matnad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@iamdefinitelyahuman iamdefinitelyahuman merged commit 30b7eb0 into master Jun 12, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the fix-parity-reverts branch June 12, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants