Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rpc.undo/redo fix #604

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Rpc.undo/redo fix #604

merged 2 commits into from
Jun 4, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

Ensure rpc.undo and rpc.redo revert to immediately before a transaction is made.

How I did it

Update the current snapshot after calls to rpc.sleep or rpc.mine.

How to verify it

Run tests. I added some new cases.

matnad
matnad approved these changes Jun 4, 2020
View reviewed changes
Copy link
Collaborator

@matnad matnad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce :)

@iamdefinitelyahuman iamdefinitelyahuman merged commit 2f0da02 into master Jun 4, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the fix-undo-rpc branch June 4, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matnad matnad matnad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamdefinitelyahuman @matnad