Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat pending nonce #597

Merged
merged 8 commits into from
Jun 3, 2020
Merged

Feat pending nonce #597

merged 8 commits into from
Jun 3, 2020

Conversation

matnad
Copy link
Collaborator

@matnad matnad commented Jun 3, 2020 •
edited
Loading

What I did

  • Add multithreading lock to send transactions from an account
  • Add support for pending nonces and set pending nonce as the default nonce to use

Closes #588

How I did it

If the last transaction from an account is still pending, the pending nonce is the nonce of this transaction plus 1

How to verify it

I added two tests.

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation
  • I have added an entry to the changelog

iamdefinitelyahuman
iamdefinitelyahuman reviewed Jun 3, 2020
View reviewed changes
Copy link
Member

@iamdefinitelyahuman iamdefinitelyahuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far looking good. Pretty straightforward after the last PR 👍

@iamdefinitelyahuman iamdefinitelyahuman merged commit dad4bff into eth-brownie:master Jun 3, 2020
@matnad matnad deleted the feat-pending-nonce branch December 28, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdefinitelyahuman iamdefinitelyahuman iamdefinitelyahuman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set nonce as "next including unconfirmed transactions"
2 participants
@matnad @iamdefinitelyahuman