Feat tx required confs #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
required_confs = 0 will no not wait for confirmation and return a pending tx
iamdefinitelyahuman
requested changes
Jun 3, 2020
remove required_confs as state, add it as function argument (remove api doc) add whitespace to "Transaction Lost.... "
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add
required_confsas an argument to transactions with a default value of 1 (same as current behaviour).Setting
required_confs = n > 1will wait for n blocks to be mined before the transaction receipt is processed.If during the confirmation time the transaction is dropped (uncle block), the transaction will wait until it is picked up again and has the required amount of confirmations.
if
required_confs == 0the transaction will immediately return a pending tx receipt and not wait for a confirmation.Add
tx.wait(n)to retroactively add required_confs and wait until they are confirmed.TODO: Still needs more documentation
Closes #587
How I did it
Added the argument to all deply, transfer and transact functions.
Refactored the confirmation logic
How to verify it
I added tests for this.
or try
accounts[0].transfer(accounts[1], "1 ether", {'required_confs': 3})Checklist