Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply timeout to all web3 connection types #549

Merged
merged 1 commit into from
May 24, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

Apply timeout to all types of web3 connections.

How to verify it

Run the tests.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2020

Codecov Report

Merging #549 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #549   +/-   ##
=======================================
  Coverage   88.19%   88.19%           
=======================================
  Files          56       56           
  Lines        6304     6304           
  Branches     1392     1392           
=======================================
  Hits         5560     5560           
  Misses        514      514           
  Partials      230      230           
Impacted Files Coverage Δ
brownie/network/web3.py 97.19% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408a973...8ed5184. Read the comment docs.

@iamdefinitelyahuman iamdefinitelyahuman merged commit c29c7d9 into master May 24, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the web3-timeout branch May 24, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants