Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return TransactionReceipt on selfdestructed deployment #546

Merged
merged 2 commits into from
May 23, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

Return a TransactionReceipt when a deployment succeeds but the contract does not exist (self destructed during deployment).

Closes #537

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2020

Codecov Report

Merging #546 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
+ Coverage   87.93%   88.00%   +0.07%     
==========================================
  Files          56       56              
  Lines        6298     6304       +6     
  Branches     1392     1392              
==========================================
+ Hits         5538     5548      +10     
+ Misses        526      523       -3     
+ Partials      234      233       -1     
Impacted Files Coverage Δ
brownie/network/account.py 94.19% <100.00%> (+0.07%) ⬆️
brownie/network/contract.py 90.94% <100.00%> (+0.40%) ⬆️
brownie/network/state.py 93.04% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a902bad...3fd8397. Read the comment docs.

@iamdefinitelyahuman iamdefinitelyahuman force-pushed the fix-selfdestructing-deploy branch from 862cfe3 to bc8d597 Compare May 23, 2020 17:53
@iamdefinitelyahuman iamdefinitelyahuman force-pushed the fix-selfdestructing-deploy branch from bc8d597 to 3fd8397 Compare May 23, 2020 17:54
@iamdefinitelyahuman iamdefinitelyahuman merged commit dea3be3 into master May 23, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the fix-selfdestructing-deploy branch May 23, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when deploying a self-destructing contract
2 participants