Windows interactive debugging fixes #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when using the console for interactive test debugging, colorama doesn't seem to have any effect. by initializing it again during the console init method, we ensure proper colorized output for windows users. admittedly this is a bandaid and not a solution, but repeated calls to colorama.init() have no effect so i don't think there are any unintended side effects or performance hit taken here.
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
==========================================
- Coverage 88.47% 88.43% -0.05%
==========================================
Files 56 56
Lines 6276 6279 +3
Branches 1386 1387 +1
==========================================
Hits 5553 5553
- Misses 494 496 +2
- Partials 229 230 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
coloramaissue on Windows related to the interactive debuggerHow I did it
BrowniePytestPlugin._path, so that the lookup innode_mapdoesn't produce aKeyErrorcoloramawithin the init process ofConsoleto ensure it properly has an effectHow to verify it
Load the interactive debugger on a Windows system.