fix: add libraries for linkage with solc in verification info #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdefinitelyahuman
approved these changes
Nov 13, 2021
Migue2004
approved these changes
Nov 21, 2021
pygeek
pushed a commit
to pygeek/brownie
that referenced
this pull request
Nov 25, 2021
…ked-libraries fix: add libraries for linkage with solc in verification info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix contract verification for contracts with linked libraries (as opposed to embedded libraries).
Fixes: #1317
How I did it
Add all libraries w/ there deployment addresses to the dictionary of compiler settings
How to verify it
Check #1317 can be compiled with solc using the standard json input from
get_verification_info()Checklist