Change use of getcontext() to fresh Context() #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdefinitelyahuman
previously approved these changes
Oct 27, 2021
charles-cooper
force-pushed
the
vyper_decimal_context
branch
from
be67fb9 to
720fb01
Compare
vyperlang/vyper#2479 disabled changes to the global decimal context to preserve compile-time constant semantics. This commit changes use of the global getcontext to a local context. It shouldn't change the behavior of the current code (since it didn't depend on modifying the global context, just having a local Context with the correct precision).
previous commit made the change to getcontext to be local. but this is only correct if vyper is imported (which sets context precision). this commit sets the context precision correctly in the case where vyper is not imported.
charles-cooper
force-pushed
the
vyper_decimal_context
branch
from
720fb01 to
32323dd
Compare
iamdefinitelyahuman
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix brownie interaction with vyper for (unreleased, probably) 0.3.1 vyper.
How I did it
vyperlang/vyper#2479 disabled changes to the
global decimal context to preserve compile-time constant semantics.
This commit changes use of the global getcontext to a local context. It
shouldn't change the behavior of the current code (since it didn't depend
on modifying the global context, just having a local Context with the
correct precision).
How to verify it
Check out with vyper HEAD. Check that brownie no longer throws an exception.
Checklist