Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support EIP1559 in TransactionReceipt.replace #1250

Merged
merged 3 commits into from
Sep 11, 2021
Merged

Support EIP1559 in TransactionReceipt.replace #1250

merged 3 commits into from
Sep 11, 2021

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

When replacing an EIP1559 transaction, create another EIP1559 transaction.

How I did it

  • The max fee is modified according to the given modifier or new absolute value.
  • The priority fee is always multiplied by 1.1, which seems to be the minimum required by Geth.

How to verify it

Try it.

@iamdefinitelyahuman iamdefinitelyahuman merged commit 1e2741c into master Sep 11, 2021
@iamdefinitelyahuman iamdefinitelyahuman deleted the feat/replace-type-2 branch September 11, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iamdefinitelyahuman