Modifications to tx flow #1182
Merged
Modifications to tx flow #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Adjust the flow of logic around making a new transaction to reduce the likelihood of a threadlock. Also improves the verbosity with a tx to show when things are still working (particularly when the tx was broadcast but has not yet shown in the mempool).
How I did it
The main thing happening here is removing the use of web3.py's
wait_for_transaction_receiptand applying similar logic directly in brownie. This gives us some more control over how everything is handled and allows the improved verbosity.For the locks, I reduced the amount of logic inside the lock to only broadcasting the actual transaction.