Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes around caching #1160

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Fixes around caching #1160

merged 2 commits into from
Jul 23, 2021

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

Fixes related to caching:

  • do not cache eth_sendTransaction and eth_sendRawTransaction responses - when combined with tx replacement this can leave the main thread stuck on a loop forever, waiting for a lock to release. Maybe related - Stuck transactions - graceful handling? #1115
  • gracefully handle any exceptions raised when creating a filter after the initial filter was created successfully. In some cases (looking at you, BSC) public nodes allow a filter to be created and queried several times, then disable and rate limit that specific endpoint. Related - deploy script returns 'Exception in thread Thread-1:'…sometimes #1159

How to verify it

Do stuff, see what breaks.

@iamdefinitelyahuman iamdefinitelyahuman merged commit 672c2cf into master Jul 23, 2021
@iamdefinitelyahuman iamdefinitelyahuman deleted the fix/send-tx-caching branch August 1, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant