Release/v1.10.0 core

[meowsbits]

Supersedes and effectively replaces #29
For rationale, please see conversation at #29 (comment) and below.

---

Release notes draft

https://github.com/etclabscore/core-geth/releases

Buffalo Buffalo Buffalo (v1.10.0)

• Implements ECIP1086. This specification is an allowance provisioning for ETC testnets Kotti and Mordor to continue to incorrectly implement EIP2200. Alternatively, the networks can be rolled back to a point prior to their implementation of EIP2200. There is not firm human consensus on this issue yet (via the Discussion-To link in ECIP1086). However, in balancing the needs to correctly implement things, to break as few things as possible, and to try to keep people on-board, we've decided to publish the ECIP1086 implementation "optimistically." This allows core-geth to not cause a fork on these testnets, and -- importantly -- does not preclude the option of rolling them back (in which case we'll simply remove the ECIP1086 feature as dead code).

• As related above, implements the EIP2200 gas cost fix.

• Implements ECIP1078 on ETC testnets Kotti and Mordor only. Similar in logic to above, this is a compromise between specification and implementation timelines (since Last Call period end is after activation on these testnets, see this PR for some discussion on this).

• And last but not least (as you may have already surmised 😉) renames the project to Core-Geth!

  • With significant development effort already invested (now approaching 800 commits ahead of our comrade and predecessor multi-geth/multi-geth), and an intention to continue growth, we think it's about the right time to fly our own flag. The aim is for this code base and the software it provides to continue serving ETC and entire Ethⁿ ecosystem reliably and innovatively. We hope that renaming won't be a cause of political contention, but instead add another optimistic rallying point for configuration-freedom and an extensible, accessible Ethereum-as-protocol. 🚀

Assets uploaded via the following CI jobs:

• https://travis-ci.org/etclabscore/core-geth/builds/653005750
• https://ci.appveyor.com/project/meowsbits/core-geth/builds/30938074

[tzdybal]

LGTM

[tzdybal]

This diff looks funny :D You have to see individual commits to see the reason :D

[eyfl]

LGTM

[soc1c]

Let's hold this back till after the call

• ref ECIP-1061: Move Aztlan to Phoenix block on Mordor; ECIP-1086 Last Call ethereumclassic/ECIPs#296
• ref ECIP1087 [Draft]: A way to resolve the ECIP1061/ECIP1078/ECIP1086/EIP2200 testnet fiasco (rollback Mordor, leave Kotti) ethereumclassic/ECIPs#295

[meowsbits]

Let's defer publishing this release until merge of #35, given that the reverted EIP2200 fix is outside of specification, and ECIP1086 is proposed as Rejected by it's author @soc1c .

We can either re-tag v1.10.0, of after that merge then tag a new v1.10.1 that would optimistically be publishable.

[meowsbits]

I'm going to merge this, but let's defer publishing the associated release; it will be better to release today or tomorrow a version v1.11.0 which includes the ECIP1088 Mordor, Kotti, and mayyyybbeeee Classic chain configs.

[q9f]

why would you jump another version?

[meowsbits]

This bumps the latest version number to v1.10.0, and unstable to v1.10.1 as discussed here and in referenced links:

Supersedes and effectively replaces #29
For rationale, please see conversation at #29 (comment) and below.

My understanding is that this version bump reflects the ECIP1078 implementation as well as the renaming change. (And that unfortunately because of the Aztlan instability (EIP2200, et al) these changes weren't publishable since they wouldn't be "stable" for the testnets.)

My plan was then to implement the necessary change set for ECIP1088 and tag and publish that release under v1.11.0 since it will (again) be a significant configuration "upgrade."

Is this a misunderstanding?