eth/filters,ethclient,node: install newSideHeads subscription #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meowsbits
commented
Jan 12, 2021
| @@ -399,6 +440,10 @@ func (es *EventSystem) lightFilterNewHead(newHeader *types.Header, callBack func | |||
| } | |||
| } | |||
|
|
|||
| func (es *EventSystem) lightFilterNewSideHead(header *types.Header, callBack func(*types.Header, bool)) { | |||
| callBack(header, true) | |||
There was a problem hiding this comment.
This is noteworthy; logs from side chain blocks will always be marked Removed: true. newHeads handling of this uses Removed to indicate the same characteristic, but in that context is expected to have been canonical, and is now removed to the side. Although the reuse of this field (and vocabulary) is a little awkward, I think it's the best we can do without modifying the existing API data type.
meowsbits
force-pushed
the
feat/eth-subscribe-newsideblocks-pr
branch
from
717cc45
to
0848955
Compare
The newSideHeads subscription work very similarly to the newHeads subscription; instead, non-canonical blocks are channeled.
meowsbits
force-pushed
the
feat/eth-subscribe-newsideblocks-pr
branch
from
0848955
to
6ae8387
Compare
Date: 2021-01-12 08:05:16-06:00 Signed-off-by: meows <[email protected]>
ziogaschr
reviewed
Jan 12, 2021
Resolves https://github.com/etclabscore/core-geth/pull/293/files/bf5bd1290fdb0ad59e8d4255100934d053be6e5d#r555805816 Date: 2021-01-12 09:54:37-06:00 Signed-off-by: meows <[email protected]>
meowsbits
force-pushed
the
feat/eth-subscribe-newsideblocks-pr
branch
from
0120632
to
c8cf61d
Compare
…over test Date: 2021-01-19 07:07:02-06:00 Signed-off-by: meows <[email protected]>
meowsbits
added a commit
that referenced
this pull request
Jan 19, 2021
#293 commit 85e4d0b Author: meows <[email protected]> Date: Tue Jan 19 07:07:02 2021 -0600 ethclient: install missing eth_newSideBlockFilter method for rpc.discover test Date: 2021-01-19 07:07:02-06:00 Signed-off-by: meows <[email protected]> commit c8cf61d Author: meows <[email protected]> Date: Tue Jan 12 09:54:37 2021 -0600 filters: (lint) fix comment Resolves https://github.com/etclabscore/core-geth/pull/293/files/bf5bd1290fdb0ad59e8d4255100934d053be6e5d#r555805816 Date: 2021-01-12 09:54:37-06:00 Signed-off-by: meows <[email protected]> commit bf5bd12 Author: meows <[email protected]> Date: Tue Jan 12 08:05:16 2021 -0600 filters: (lint) goimports Date: 2021-01-12 08:05:16-06:00 Signed-off-by: meows <[email protected]> commit 6ae8387 Author: meows <[email protected]> Date: Mon Jan 11 18:13:48 2021 -0600 eth/filters,ethclient,node: install newSideHeads subscription The newSideHeads subscription work very similarly to the newHeads subscription; instead, non-canonical blocks are channeled.
|
Merged with 9422e73 on the CLI: |
This was referenced Jan 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newSideHeads subscription work very similarly to
the newHeads subscription; instead, non-canonical blocks are channeled.
Resolves #287