Fix status dot never appearing #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
JoshTheWanderer
approved these changes
May 10, 2023
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In storybook v7 we've stopped recieving the story's parameters inside the renderLabel
itemobject.I've tried using all the methods on the API to receive the parameters but none of them provide good results.
This PR contains a best effort which is to use the
getParametersmethod to retrieve the stories parameters based on theitem.id. Unfortunately this never loads in the parameters for the story correctly until the story has been loaded, so we only get dots after the story has been visited as shown in the attached.Screen.Cast.2023-05-10.at.11.45.13.AM.mp4
Related #28