chore(build): exclude annotation JARs from jetcd-all "fat" JAR #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lburgazzoli OK for you? |
Closed
vorburger
added a commit
to vorburger/opendaylight-etcd
that referenced
this pull request
Feb 6, 2019
Because I suspected that may be responsible for the problem under Karaf. Use shaded version of ByteString in the EtcdWatcherSplittingConsumerTest and fix the duplicate-finder-maven-plugin problem with exclusions see also etcd-io/jetcd#493
vorburger
added a commit
to vorburger/opendaylight-etcd
that referenced
this pull request
Feb 6, 2019
vorburger
added a commit
to vorburger/opendaylight-etcd
that referenced
this pull request
Feb 6, 2019
because they are not needed at run-time and only bloat the "fat" JAR and can cause conflicts when building other projects depending on this: [INFO] --- duplicate-finder-maven-plugin:1.3.0:check(find-duplicate-classpath-entries) @ jetcd --- [WARNING] Found duplicate and different classes in [io.etcd:jetcd-all:0.3.0-SNAPSHOT, org.checkerframework:checker-compat-qual:2.5.3]: [WARNING] org.checkerframework.checker.nullness.compatqual.KeyForDecl [WARNING] org.checkerframework.checker.nullness.compatqual.KeyForType [WARNING] org.checkerframework.checker.nullness.compatqual.MonotonicNonNullDecl [WARNING] org.checkerframework.checker.nullness.compatqual.MonotonicNonNullType [WARNING] org.checkerframework.checker.nullness.compatqual.NonNullDecl [WARNING] org.checkerframework.checker.nullness.compatqual.NonNullType [WARNING] org.checkerframework.checker.nullness.compatqual.NullableDecl [WARNING] org.checkerframework.checker.nullness.compatqual.NullableType [WARNING] org.checkerframework.checker.nullness.compatqual.PolyNullDecl [WARNING] org.checkerframework.checker.nullness.compatqual.PolyNullType [WARNING] Found duplicate and different classes in [io.etcd:jetcd-all:0.3.0-SNAPSHOT, org.codehaus.mojo:animal-sniffer-annotations:1.14]: [WARNING] org.codehaus.mojo.animal_sniffer.IgnoreJRERequirement [WARNING] Found duplicate classes/resources in test classpath.
vorburger
force-pushed
the
all-without-annotations
branch
from
93978d6 to
37b1c1a
Compare
lburgazzoli
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because they are not needed at run-time and only bloat the "fat" JAR
and can cause conflicts when building other projects depending on this:
[INFO] --- duplicate-finder-maven-plugin:1.3.0:check(find-duplicate-classpath-entries) @ jetcd ---
[WARNING] Found duplicate and different classes in [io.etcd:jetcd-all:0.3.0-SNAPSHOT, org.checkerframework:checker-compat-qual:2.5.3]:
[WARNING] org.checkerframework.checker.nullness.compatqual.KeyForDecl
[WARNING] org.checkerframework.checker.nullness.compatqual.KeyForType
[WARNING] org.checkerframework.checker.nullness.compatqual.MonotonicNonNullDecl
[WARNING] org.checkerframework.checker.nullness.compatqual.MonotonicNonNullType
[WARNING] org.checkerframework.checker.nullness.compatqual.NonNullDecl
[WARNING] org.checkerframework.checker.nullness.compatqual.NonNullType
[WARNING] org.checkerframework.checker.nullness.compatqual.NullableDecl
[WARNING] org.checkerframework.checker.nullness.compatqual.NullableType
[WARNING] org.checkerframework.checker.nullness.compatqual.PolyNullDecl
[WARNING] org.checkerframework.checker.nullness.compatqual.PolyNullType
[WARNING] Found duplicate and different classes in [io.etcd:jetcd-all:0.3.0-SNAPSHOT, org.codehaus.mojo:animal-sniffer-annotations:1.14]:
[WARNING] org.codehaus.mojo.animal_sniffer.IgnoreJRERequirement
[WARNING] Found duplicate classes/resources in test classpath.