Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: add "etcd_server_go_version" metric #9957

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Jul 23, 2018

Currently, one has to look at server logs manually,
to see what Go version was used to build etcd server.

# TYPE etcd_server_go_version gauge
etcd_server_go_version{server_go_version="go1.10.3"} 1

@wenjiaswe

Currently, one has to look at server logs manually,
to see what Go version was used to build etcd server.

Signed-off-by: Gyuho Lee <[email protected]>
@xiang90
Copy link
Contributor

xiang90 commented Jul 23, 2018

lgtm

@codecov-io
Copy link

Codecov Report

Merging #9957 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9957      +/-   ##
==========================================
+ Coverage   69.02%   69.03%   +<.01%     
==========================================
  Files         386      386              
  Lines       35788    35792       +4     
==========================================
+ Hits        24704    24710       +6     
+ Misses       9282     9271      -11     
- Partials     1802     1811       +9
Impacted Files Coverage Δ
etcdserver/metrics.go 64.58% <100%> (+3.21%) ⬆️
etcdserver/util.go 81.25% <0%> (-13.75%) ⬇️
etcdserver/api/v3rpc/lease.go 65.9% <0%> (-11.37%) ⬇️
pkg/netutil/netutil.go 63.11% <0%> (-6.56%) ⬇️
clientv3/namespace/watch.go 72.72% <0%> (-6.07%) ⬇️
pkg/logutil/zap_grpc.go 47.61% <0%> (-4.77%) ⬇️
proxy/grpcproxy/watcher.go 85.71% <0%> (-4.09%) ⬇️
proxy/httpproxy/director.go 80% <0%> (-2.86%) ⬇️
etcdserver/api/v3election/election.go 66.66% <0%> (-2.78%) ⬇️
etcdserver/api/v3rpc/watch.go 74.18% <0%> (-2.29%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0458c5d...643d791. Read the comment docs.

@wenjiaswe
Copy link
Contributor

LGTM
Will this be tested and documented?

@gyuho
Copy link
Contributor Author

gyuho commented Jul 23, 2018

@wenjiaswe Yes, I will document in changelogs, but don't think it needs be tested :)

@gyuho gyuho merged commit 3f725e1 into etcd-io:master Jul 23, 2018
@gyuho gyuho deleted the go-version branch July 23, 2018 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants