etcdctl: don't ask password twice for etcdctl endpoint health --cluster #9136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current etcdctl endpoint health --cluster asks password twice if auth is enabled. This is because the command creates two client instances: one for the purpose of checking endpoint health and another for getting cluster members with MemberList(). The latter client doesn't need to be authenticated because MemberList() is a public RPC. This commit makes the client with no authed one. Fix etcd-io#9094
Codecov Report
@@ Coverage Diff @@
## master #9136 +/- ##
========================================
Coverage ? 75.9%
========================================
Files ? 359
Lines ? 30004
Branches ? 0
========================================
Hits ? 22775
Misses ? 5641
Partials ? 1588
Continue to review full report at Codecov.
|
|
Confirmed that it fixes: $ ETCDCTL_API=3 ./bin/etcdctl endpoint health --cluster
http://127.0.0.1:22379 is unhealthy: failed to commit proposal: etcdserver: user name is empty
http://127.0.0.1:2379 is unhealthy: failed to commit proposal: etcdserver: user name is empty
http://127.0.0.1:32379 is unhealthy: failed to commit proposal: etcdserver: user name is empty
Error: unhealthy cluster
$ ETCDCTL_API=3 ./bin/etcdctl --user root:123 endpoint health --cluster
http://127.0.0.1:22379 is healthy: successfully committed proposal: took = 1.135362ms
http://127.0.0.1:32379 is healthy: successfully committed proposal: took = 1.573943ms
http://127.0.0.1:2379 is healthy: successfully committed proposal: took = 1.199876ms |
|
Thanks @mitake ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current etcdctl endpoint health --cluster asks password twice if auth
is enabled. This is because the command creates two client instances:
one for the purpose of checking endpoint health and another for
getting cluster members with MemberList(). The latter client doesn't
need to be authenticated because MemberList() is a public RPC. This
commit makes the client with no authed one.
Fix #9094
/cc @lyddragon @gyuho @hexfusion