Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: log stream error with debug level, silence gRPC server info level logs #9080

Merged
merged 4 commits into from
Jan 2, 2018

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Jan 2, 2018

Make logs from #8939 to debug level.
etcd server logs were getting too verbose when there are lots of canceled streams.

Also silence gRPC info level server logs (balancer logs).

ref. kubernetes/kubernetes#57480

Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gyuho gyuho added the WIP label Jan 2, 2018
@gyuho
Copy link
Contributor Author

gyuho commented Jan 2, 2018

@jpbetz I will merge this after CI passes, and release new 3.2 this week. Hopefully help debug kubernetes/kubernetes#57480.

@gyuho gyuho merged commit 916d9db into etcd-io:master Jan 2, 2018
@gyuho gyuho deleted the log-debug branch January 2, 2018 19:01
@gyuho gyuho removed the WIP label Jan 3, 2018
@paulcaskey
Copy link

paulcaskey commented Jun 18, 2020

This verbose logging seems to be back in 3.4. I upgraded from 3.3.20 to 3.4.9 and now get "read: connection reset by peer" whenever my Go clientv3 calls Close(). I don't have debug logging enabled. I do have ETCD_LOGGER=zap because otherwise I get a warning about log format. In fact the log shows "level":"warn" on these messages.

I tried updating both go-grpc and etcd-clientv3 to the latest releases, and rebuilding my client source code. Still see this problem.

@Sarga
Copy link

Sarga commented Oct 19, 2020

I have same issue with verbose logging after upgrade etcd to 3.4.13

@tangcong
Copy link
Contributor

@paulcaskey @Sarga I have submitted pr #12406 to silence the stream error log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants