-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client/v2: regenerate with latest ugorji/go/codec #8721
Conversation
@andrewmeissner Could you format your commit titles to something like
And does client build after your patch? |
Updating github.com/ugorji/go/codec to the latest commit/version
Updating the codec required codecgen to be reran on the client/keys.go file. This is the result of that run.
@gyuho I updated the commit messages. I ran a |
@andrewmeissner It doesn't build in our CIs. Did you run |
ran the updatedep.sh
@gyuho I was not aware (hahaha). Just ran it and committed the files it modified. :) |
Thanks! We will merge this when CI passes. |
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
@ugorji We had to manually patch the generated code to pass our linting tests. |
@gyuho thanks much for the heads up. I will look into why the redundant stuff was there, and the yhnn2=0 one also. |
Updating the github.com/ugorji/go/codec dependency to the latest and regenerates the keys.[generated].go file with the updated codecgen executable.