Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation/v2: remove implementation detail #8435

Merged
merged 1 commit into from
Aug 24, 2017
Merged

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Aug 22, 2017

etcd init command does not exist.

@gyuho gyuho requested review from xiang90 and heyitsanthony August 22, 2017 17:22
@heyitsanthony
Copy link
Contributor

should the etcd init stuff be removed entirely? I don't think it was ever in 2.x and 0.4 is officially deprecated

@gyuho gyuho added the WIP label Aug 22, 2017
@gyuho gyuho changed the title Documentation/v2: add notes to 'etcd init' command Documentation/v2: remove implementation detail Aug 23, 2017
@gyuho gyuho removed the WIP label Aug 23, 2017
@gyuho
Copy link
Contributor Author

gyuho commented Aug 23, 2017

Just removed the whole doc. Would it break anything? I don't see anywhere it's referenced.

@heyitsanthony
Copy link
Contributor

I think it's fine to remove since it's disconnected form the rest of the docs. However, it's also explaining design choices for the boot ux (e.g., why etcd doesn't have `etcd init``), should the content be preserved / moved somewhere more sensible? /cc @xiang90

@xiang90
Copy link
Contributor

xiang90 commented Aug 24, 2017

lgtm

@gyuho gyuho merged commit 752c161 into etcd-io:master Aug 24, 2017
@gyuho gyuho deleted the doc branch August 24, 2017 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants