Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration/fixtures: fix base64 flag, add wildcard.json #8364

Merged
merged 1 commit into from
Aug 3, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Aug 3, 2017

MacOS base64 uses -D and linux uses -d, while --decode
works on both platforms. And add missing server-ca-csr-wildcard.json.

"CN": "example.com",
"hosts": [
"*.etcd.local",
"127.0.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the one I forgot to include in the original patch (oops) has this:

  "hosts": [
    "*.etcd.local"
  ]

which skips the IP SAN check and forces the DNS SAN path

Copy link
Contributor

@heyitsanthony heyitsanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

MacOS base64 uses -D and linux uses -d, while --decode
works on both platforms. And add missing server-ca-csr-wildcard.json.

Signed-off-by: Gyu-Ho Lee <[email protected]>
@gyuho gyuho merged commit 71a7065 into etcd-io:master Aug 3, 2017
@gyuho gyuho deleted the fixtures branch August 3, 2017 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants