Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: fill a response header in auth RPCs #7716

Closed
wants to merge 1 commit into from

Conversation

mitake
Copy link
Contributor

@mitake mitake commented Apr 12, 2017

@xiang90
Copy link
Contributor

xiang90 commented Apr 12, 2017

probably we should add some tests around this.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@6ebadda). Click here to learn what that means.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7716   +/-   ##
=========================================
  Coverage          ?   75.35%           
=========================================
  Files             ?      330           
  Lines             ?    25968           
  Branches          ?        0           
=========================================
  Hits              ?    19567           
  Misses            ?     4984           
  Partials          ?     1417
Impacted Files Coverage Δ
etcdserver/api/v3rpc/auth.go 71.05% <81.81%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ebadda...5e0f9eb. Read the comment docs.

@heyitsanthony
Copy link
Contributor

heyitsanthony commented Apr 12, 2017

this isn't guaranteed to give the revision at the time of the update/request, if that matters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants