Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rafthttp: add peer stream metrics #7682

Closed
wants to merge 1 commit into from

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Apr 6, 2017

No description provided.

@gyuho gyuho added this to the unplanned milestone Apr 19, 2017
@gyuho
Copy link
Contributor Author

gyuho commented Apr 19, 2017

Just leave this as future reference in case someone asks.
Currently we don't have any use case of it. If anyone needs to
count the connection between peers, this might be useful.
Right now, only way to find out is just looking at the logs.

e.g. with this patch, in 5-node cluster, etcd_network_peer_active_total
should be 20 (4 peers * 5 connections each).

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@04fc57a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7682   +/-   ##
=========================================
  Coverage          ?   75.92%           
=========================================
  Files             ?      331           
  Lines             ?    26088           
  Branches          ?        0           
=========================================
  Hits              ?    19807           
  Misses            ?     4850           
  Partials          ?     1431
Impacted Files Coverage Δ
rafthttp/peer_status.go 87.09% <100%> (ø)
rafthttp/metrics.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04fc57a...83adcb2. Read the comment docs.

@gyuho gyuho removed the WIP label Apr 20, 2017
@gyuho gyuho force-pushed the master branch 2 times, most recently from 44ca396 to 4301f49 Compare June 2, 2017 15:53
@xiang90
Copy link
Contributor

xiang90 commented Jun 18, 2017

when we remove the peer from the network, do we call inactive? if not, we probably also need to dec the counter there.

@xiang90
Copy link
Contributor

xiang90 commented Jun 18, 2017

e.g. with this patch, in 5-node cluster, etcd_network_peer_active_total
should be 20 (4 peers * 5 connections each).

we'd either make this 4 or change the metrics name to active_peer_connection with peer name as label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants