-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clientv3: added test for client metrics #6748
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,169 @@ | ||
// Copyright 2016 The etcd Authors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package integration | ||
|
||
import ( | ||
"bufio" | ||
"io" | ||
"net" | ||
"net/http" | ||
"strconv" | ||
"strings" | ||
"testing" | ||
"time" | ||
|
||
"github.com/coreos/etcd/clientv3" | ||
"github.com/coreos/etcd/integration" | ||
"github.com/coreos/etcd/pkg/testutil" | ||
"github.com/coreos/etcd/pkg/transport" | ||
|
||
"github.com/prometheus/client_golang/prometheus" | ||
"golang.org/x/net/context" | ||
) | ||
|
||
func TestV3ClientMetrics(t *testing.T) { | ||
defer testutil.AfterTest(t) | ||
|
||
var ( | ||
addr string = "localhost:27989" | ||
ln net.Listener | ||
err error | ||
) | ||
|
||
// listen for all prometheus metrics | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove the comments please. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @xiang90 only this comment or all the comments? |
||
donec := make(chan struct{}) | ||
go func() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. test should probably wait until this goroutine completes,
|
||
defer close(donec) | ||
|
||
srv := &http.Server{Handler: prometheus.Handler()} | ||
srv.SetKeepAlivesEnabled(false) | ||
|
||
ln, err = transport.NewUnixListener(addr) | ||
if err != nil { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. always put the error checking right after the operation? no empty lines between them. thanks! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok sure will keep in mind from next time. |
||
t.Fatalf("Error : %v occured while listening on addr : %v", err, addr) | ||
} | ||
|
||
err = srv.Serve(ln) | ||
if err != nil && !strings.Contains(err.Error(), "use of closed network connection") { | ||
t.Fatalf("Err serving http requests: %v", err) | ||
} | ||
}() | ||
|
||
url := "unix://" + addr + "/metrics" | ||
|
||
clus := integration.NewClusterV3(t, &integration.ClusterConfig{Size: 1}) | ||
defer clus.Terminate(t) | ||
|
||
client := clus.Client(0) | ||
|
||
w := clientv3.NewWatcher(client) | ||
defer w.Close() | ||
|
||
kv := clientv3.NewKV(client) | ||
|
||
wc := w.Watch(context.Background(), "foo") | ||
|
||
wBefore := sumCountersForMetricAndLabels(t, url, "grpc_client_msg_received_total", "Watch", "bidi_stream") | ||
|
||
pBefore := sumCountersForMetricAndLabels(t, url, "grpc_client_started_total", "Put", "unary") | ||
|
||
_, err = kv.Put(context.Background(), "foo", "bar") | ||
if err != nil { | ||
t.Errorf("Error putting value in key store") | ||
} | ||
|
||
pAfter := sumCountersForMetricAndLabels(t, url, "grpc_client_started_total", "Put", "unary") | ||
if pBefore+1 != pAfter { | ||
t.Errorf("grpc_client_started_total expected : %d, got : %d", 1, pAfter-pBefore) | ||
} | ||
|
||
// consume watch response | ||
select { | ||
case <-wc: | ||
case <-time.After(10 * time.Second): | ||
t.Error("Timeout occured for getting watch response") | ||
} | ||
|
||
wAfter := sumCountersForMetricAndLabels(t, url, "grpc_client_msg_received_total", "Watch", "bidi_stream") | ||
if wBefore+1 != wAfter { | ||
t.Errorf("grpc_client_msg_received_total expected : %d, got %d", 1, wAfter-wBefore) | ||
} | ||
|
||
ln.Close() | ||
<-donec | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
func sumCountersForMetricAndLabels(t *testing.T, url string, metricName string, matchingLabelValues ...string) int { | ||
count := 0 | ||
for _, line := range getHTTPBodyAsLines(t, url) { | ||
ok := true | ||
if !strings.HasPrefix(line, metricName) { | ||
continue | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok := true |
||
for _, labelValue := range matchingLabelValues { | ||
if !strings.Contains(line, `"`+labelValue+`"`) { | ||
ok = false | ||
break | ||
} | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if !ok { There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok will do it this way |
||
if !ok { | ||
continue | ||
} | ||
|
||
valueString := line[strings.LastIndex(line, " ")+1 : len(line)-1] | ||
valueFloat, err := strconv.ParseFloat(valueString, 32) | ||
if err != nil { | ||
t.Fatalf("failed parsing value for line: %v and matchingLabelValues : %v \n", line, matchingLabelValues) | ||
} | ||
count += int(valueFloat) | ||
} | ||
return count | ||
} | ||
|
||
func getHTTPBodyAsLines(t *testing.T, url string) []string { | ||
cfgtls := transport.TLSInfo{} | ||
tr, err := transport.NewTransport(cfgtls, time.Second) | ||
if err != nil { | ||
t.Fatalf("Error getting transport : %v", err) | ||
} | ||
|
||
tr.MaxIdleConns = -1 | ||
tr.DisableKeepAlives = true | ||
|
||
cli := &http.Client{Transport: tr} | ||
|
||
resp, err := cli.Get(url) | ||
if err != nil { | ||
t.Fatalf("Error fetching: %v", err) | ||
} | ||
|
||
reader := bufio.NewReader(resp.Body) | ||
lines := []string{} | ||
for { | ||
line, err := reader.ReadString('\n') | ||
if err != nil { | ||
if err == io.EOF { | ||
break | ||
} else { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we don't need this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @gyuho We need this else for terminating if some un-expected error occurs. |
||
t.Fatalf("error reading: %v", err) | ||
} | ||
} | ||
lines = append(lines, line) | ||
} | ||
resp.Body.Close() | ||
return lines | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this var into go routine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xiang90 cannot move this into go routine since we have to close the listener outside the go-routine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ok. what about err one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that err can be re-used for put check as well which you have asked to put now.