integration: add TestV3WatchWithPrevKV #6591
Conversation
There was a problem hiding this comment.
I think this kind of test belongs in ./integration and not ./clientv3/integration since it's testing the server API? /cc @xiang90
| if tt.vals[0] != string(watchResp.Events[0].PrevKv.Value) { | ||
| t.Errorf("#%d: unequal value: want=%s, get=%s", i, tt.vals[0], watchResp.Events[0].PrevKv.Value) | ||
| } | ||
| case <-ctx.Done(): |
There was a problem hiding this comment.
this should raise a timeout error
| for i, tt := range tests { | ||
| ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second) | ||
|
|
||
| etcdcli.Put(ctx, tt.key, tt.vals[0]) |
|
|
||
| etcdcli.Put(ctx, tt.key, tt.vals[0]) | ||
| wch := etcdcli.Watch(ctx, tt.key, clientv3.WithPrefix(), clientv3.WithPrevKV()) | ||
| etcdcli.Put(ctx, tt.key, tt.vals[1]) |
|
let's move this to integration. i think we already have this test somewhere, no? |
|
@xiang90 there's a test for delete prevkV but nothing for watchers. |
hongchaodeng
changed the title
|
@heyitsanthony |
| t.Fatalf("fail to Put: %v", err) | ||
| } | ||
|
|
||
| wch := etcdcli.Watch(ctx, tt.key, clientv3.WithPrefix(), clientv3.WithPrevKV()) |
There was a problem hiding this comment.
the tests in this file are supposed to use the grpc interface...
There was a problem hiding this comment.
Can we have another place (another dir or file) to test using native clients?
It would be beneficial since users can look into the test and reuse the code.
There was a problem hiding this comment.
example should not be in the test. example should be in the doc or client example code.
There was a problem hiding this comment.
clientv3/integration has native client tests.
integration does not depend on clientv3 code, As @heyitsanthony mentioned, for this test, we just want to test the correctness of server side and grpc calls?
No description provided.