Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdmain: drop journald output #6450

Closed
wants to merge 1 commit into from
Closed

etcdmain: drop journald output #6450

wants to merge 1 commit into from

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Sep 16, 2016

@xiang90
Copy link
Contributor

xiang90 commented Sep 16, 2016

I believe @jonboulle and @philips suggests log directly to stdout by default.

I also think it is better.

@gyuho
Copy link
Contributor Author

gyuho commented Sep 16, 2016

@xiang90 Changed it to stdout by default.

capnslog defaults to stderr, by the way.

@gyuho gyuho changed the title *: set logging to stdout etcdmain: drop journald output Sep 16, 2016
@gyuho
Copy link
Contributor Author

gyuho commented Sep 16, 2016

@xiang90 Now it just overwrites NewDefaultFormatter https://github.com/coreos/pkg/blob/master/capnslog/init.go#L36-L40 to drop journald

PTAL.

@xiang90
Copy link
Contributor

xiang90 commented Sep 16, 2016

@gyuho I am fine with this. Please wait for @jonboulle and @philips's opinion on this one. Thanks.

@gyuho
Copy link
Contributor Author

gyuho commented Nov 3, 2016

Closing in preference of #6799

@gyuho gyuho closed this Nov 3, 2016
@gyuho gyuho deleted the set-logging branch November 3, 2016 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gyuho @xiang90