Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: re-enable building outside gopath #6198

Merged
merged 1 commit into from
Aug 18, 2016

Conversation

heyitsanthony
Copy link
Contributor

oops

@gyuho
Copy link
Contributor

gyuho commented Aug 17, 2016

LGTM. Thanks!

@heyitsanthony
Copy link
Contributor Author

going to add a test for this in travis so it doesn't break again

@heyitsanthony heyitsanthony force-pushed the reenable-outside-gopath branch 2 times, most recently from e5747f1 to 83dd121 Compare August 17, 2016 03:04

Verified

This commit was signed with the committer’s verified signature.
MaxymVlasov Maksym Vlasov
Have build return an error code if build fails and add a test to travis
to confirm running build outside the gopath works.
@heyitsanthony heyitsanthony merged commit cc4f4b4 into etcd-io:master Aug 18, 2016
@heyitsanthony heyitsanthony deleted the reenable-outside-gopath branch August 24, 2016 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants