test: certificate fixes for fedora #5877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some systems don't support EC due to patent issues, but the tests should still work. Fixes etcd-io#5744
| @@ -139,10 +139,10 @@ func cURLPrefixArgs(clus *etcdProcessCluster, method string, req cURLReq) []stri | |||
| if clus.cfg.clientTLS != clientTLSAndNonTLS { | |||
| panic("should not use cURLPrefixArgsUseTLS when serving only TLS or non-TLS") | |||
| } | |||
| cmdArgs = append(cmdArgs, "--cacert", caPath, "--cert", certPath, "--key", privateKeyPath) | |||
| cmdArgs = append(cmdArgs, "--cacert", caPath, "--cert", pkcs12Path+":123", "--cert-type", "P12") | |||
There was a problem hiding this comment.
password; I tried making it with a blank password but curl still complained asking for one
|
lgtm. Defer to @xiang90 |
heyitsanthony
changed the title
|
nuking the P12 cert commit since CI doesn't support it |
heyitsanthony
force-pushed
the
rsa-fixtures
branch
from
eef0594 to
c642430
Compare
|
lgtm |
|
holding off on merge until I can test on a fedora vm tonight |
|
tested and works, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fedora doesn't support ECDSA and darwin's curl wants pkcs12 certs