Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3benchmark: add put benchmark #3544

Merged
merged 1 commit into from
Sep 17, 2015
Merged

v3benchmark: add put benchmark #3544

merged 1 commit into from
Sep 17, 2015

Conversation

xiang90
Copy link
Contributor

@xiang90 xiang90 commented Sep 16, 2015

/cc @yichengq

yichengq
yichengq reviewed Sep 16, 2015
View reviewed changes
tools/v3benchmark/main.go
benchGet(conn, key, rangeEnd, n, c)
} else if act == "put" {
key := []byte(flag.Args()[1])
kc, err := strconv.ParseInt(flag.Args()[2], 10, 32)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is kc? could we add a comment for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@yichengq
Copy link
Contributor

lgtm

xiang90 added a commit that referenced this pull request Sep 17, 2015
@xiang90
Merge pull request #3544 from xiang90/bench
c4b3ad7 
v3benchmark: add put benchmark
@xiang90 xiang90 merged commit c4b3ad7 into etcd-io:master Sep 17, 2015
@xiang90 xiang90 deleted the bench branch September 17, 2015 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiang90 @yichengq