Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-12-16] Manual Dependency Bump #19080

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

@ArkaSaha30
Copy link
Contributor Author

/test pull-etcd-verify

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.85%. Comparing base (0966b4d) to head (ce511f6).
Report is 11 commits behind head on main.

Additional details and impacted files

see 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19080      +/-   ##
==========================================
+ Coverage   68.71%   68.85%   +0.14%     
==========================================
  Files         420      420              
  Lines       35640    35641       +1     
==========================================
+ Hits        24489    24541      +52     
+ Misses       9723     9674      -49     
+ Partials     1428     1426       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0966b4d...ce511f6. Read the comment docs.

@ArkaSaha30 ArkaSaha30 force-pushed the deps_mgmt_16_12_24 branch 2 times, most recently from 1676816 to 4f55356 Compare December 18, 2024 15:48
@ArkaSaha30
Copy link
Contributor Author

/retest-required

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ArkaSaha30, thanks for your pull request.

  • I'd like to suggest squashing commits c7ebd0f and 4f55356 (but I'd say it's a no biggie).
  • However, I think you forgot to bump bump go.opentelemetry.io/otel/exporters/otlp/otlptrace as commit c7ebd0f doesn't include it.

@ArkaSaha30
Copy link
Contributor Author

  • I'd like to suggest squashing commits c7ebd0f and 4f55356 (but I'd say it's a no biggie).
  • However, I think you forgot to bump bump go.opentelemetry.io/otel/exporters/otlp/otlptrace as commit c7ebd0f doesn't include it.

Sure, thank you! Updating the PR with the changes

This commit will bump dependency go.opentelemetry.io/otel from 1.32.0 to 1.33.0

Signed-off-by: ArkaSaha30 <[email protected]>
This commit will bump dependency google.golang.org/protobuf from 1.35.2 to 1.36.0

Signed-off-by: ArkaSaha30 <[email protected]>
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ArkaSaha30

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ArkaSaha30, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 9fa35e5 into etcd-io:main Dec 19, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants