Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the allowedErrors in TestNoErrorLogsDuringNormalOperations #19069

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Dec 16, 2024

Revert #19060.

After #19068 is merged, we shouldn't see the following error anymore,

Messages:   	error level log message found: {"level":"error","ts":"2024-11-16T20:58:00.500222Z","caller":"version/monitor.go:120","msg":"failed to update storage version","cluster-version":"3.6.0","error":"cannot detect storage schema version: missing confstate information","stacktrace":"go.etcd.io/etcd/server/v3/etcdserver/version.(*Monitor).UpdateStorageVersionIfNeeded\n\tgo.etcd.io/etcd/server/v3/etcdserver/version/monitor.go:120\ngo.etcd.io/etcd/server/v3/etcdserver.(*EtcdServer).monitorStorageVersion\n\tgo.etcd.io/etcd/server/v3/etcdserver/server.go:2286\ngo.etcd.io/etcd/server/v3/etcdserver.(*EtcdServer).GoAttach.func1\n\tgo.etcd.io/etcd/server/v3/etcdserver/server.go:2467"}

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.78%. Comparing base (66b09ea) to head (425e5b8).
Report is 2 commits behind head on main.

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19069      +/-   ##
==========================================
- Coverage   68.87%   68.78%   -0.09%     
==========================================
  Files         420      420              
  Lines       35627    35627              
==========================================
- Hits        24538    24507      -31     
- Misses       9667     9693      +26     
- Partials     1422     1427       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66b09ea...425e5b8. Read the comment docs.

@ahrtr ahrtr merged commit e0bbea9 into etcd-io:main Dec 16, 2024
36 checks passed
@ahrtr ahrtr deleted the storageversion_error_20241216 branch December 16, 2024 14:55
@ahrtr
Copy link
Member Author

ahrtr commented Dec 16, 2024

cc @ghouscht

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants