-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2024-07-29] Manual Dependency Bump #18384
Conversation
5266847
to
a9fe022
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 419 files with indirect coverage changes @@ Coverage Diff @@
## main #18384 +/- ##
=========================================
+ Coverage 0 68.66% +68.66%
=========================================
Files 0 419 +419
Lines 0 35435 +35435
=========================================
+ Hits 0 24330 +24330
- Misses 0 9686 +9686
- Partials 0 1419 +1419 Continue to review full report in Codecov by Sentry.
|
…0 to 2.21.0 This commit will bump dependency bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.20.0 to 2.21.0 raised by dependabot. Signed-off-by: ArkaSaha30 <[email protected]>
abaf079
to
596458b
Compare
Thanks @ArkaSaha30 . Could you please update the second commit's message to contain the exact command you executed? |
Update genproto after *.proto change: * Please rerun genproto.sh after changing *.proto file * Run ./scripts/genproto.sh Error encountered: [0;31mFAIL: 'genproto' FAILED at Wed Jul 31 07:09:08 UTC 2024 make: *** [Makefile:134: verify-genproto] Error 255 Signed-off-by: ArkaSaha30 <[email protected]>
596458b
to
6a17ce3
Compare
Yes, I have just added in the command to run and the error encountered in the commit message |
Thanks, please also consider to update https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/dependency_management.md in a separate PR, thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @ArkaSaha30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @ArkaSaha30
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ArkaSaha30, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
This pull request completes this week's etcd dependency updates following our dependency roster and dependency management instructions.
Dependabot raised raised the following PRs:
Bumped:
Purely Indirect: