Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress noisy basic auth token deletion log #18245

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Suppress noisy basic auth token deletion log #18245

merged 1 commit into from
Jul 2, 2024

Conversation

ahmetb
Copy link
Contributor

@ahmetb ahmetb commented Jun 28, 2024 •
edited
Loading

Right now the basic auth tokens that are deleted after --auth-token-ttl cause info-level logs to be emitted. Change this to debug. This helps with the issue at #18244 where calling /readyz frequently pollutes the etcd server logs with this log message.

Fixes #18244.

Cherry-picked into 3.5.x release #18265

@ahmetb
Suppress noisy basic auth token deletion log
ec289a8 
Right now the basic auth tokens that are deleted after `--auth-token-ttl`
cause info-level logs to be emitted. Change this to debug. This helps with
the issue at etcd-io#18244 where calling `/readyz` frequently pollutes the etcd server
logs with this log message.

Fixes etcd-io#18244.

Signed-off-by: Ahmet Alp Balkan <[email protected]>
@k8s-ci-robot
Copy link

Hi @ahmetb. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmhbnz
Copy link
Member

jmhbnz commented Jun 28, 2024

/ok-to-test

@ivanvc
Copy link
Member

ivanvc commented Jun 29, 2024

It looks like GitHub workflows didn't run even though the ok-to-test label is set after running /ok-to-test 🤔

@jmhbnz jmhbnz closed this Jun 29, 2024
@jmhbnz jmhbnz reopened this Jun 29, 2024
@jmhbnz
Copy link
Member

jmhbnz commented Jun 29, 2024

It looks like GitHub workflows didn't run even though the ok-to-test label is set after running /ok-to-test 🤔

GitHub issue - closed and re-opened to re-trigger. Fixed.

@ahmetb ahmetb mentioned this pull request Jul 1, 2024
Closed
jmhbnz
jmhbnz approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ahmetb

ivanvc
ivanvc approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ahmetb.

@serathius serathius merged commit bf78a23 into etcd-io:main Jul 2, 2024
50 checks passed
@ahmetb
Copy link
Contributor Author

ahmetb commented Jul 2, 2024

/cherrypick release-3.5

@k8s-infra-cherrypick-robot
Copy link

@ahmetb: only etcd-io org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherrypick release-3.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented Jul 2, 2024

/cherrypick release-3.5

@k8s-infra-cherrypick-robot
Copy link

@ivanvc: new pull request created: #18265

In response to this:

/cherrypick release-3.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 2, 2024
Merged
@jmhbnz jmhbnz mentioned this pull request Jul 5, 2024
Closed
4 tasks
@chaosi-zju chaosi-zju mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@siyuanfoundation siyuanfoundation siyuanfoundation approved these changes

@serathius serathius serathius approved these changes

@ivanvc ivanvc ivanvc approved these changes

Assignees
No one assigned
Labels
backport/v3.5 ok-to-test size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enabling authentication causes noisy logs for every /readyz call
7 participants
@ahmetb @k8s-ci-robot @jmhbnz @ivanvc @k8s-infra-cherrypick-robot @serathius @siyuanfoundation