Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport-3.5] server: ignore raft messages if member id mismatch #17813

Conversation

@k8s-ci-robot
Copy link

Hi @henrybear327. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@henrybear327 henrybear327 force-pushed the backport-3.5/ignore-raft-messages-if-member-id-mismatch branch from 081a55c to 355be63 Compare April 17, 2024 11:25
@henrybear327 henrybear327 changed the title [backport] server: ignore raft messages if member id mismatch #17078 [backport] server: ignore raft messages if member id mismatch Apr 17, 2024
@henrybear327 henrybear327 changed the title [backport] server: ignore raft messages if member id mismatch [backport-3.5] server: ignore raft messages if member id mismatch Apr 17, 2024
@henrybear327 henrybear327 force-pushed the backport-3.5/ignore-raft-messages-if-member-id-mismatch branch from 355be63 to 9331ee3 Compare April 17, 2024 11:50
@ahrtr
Copy link
Member

ahrtr commented Apr 18, 2024

/ok-to-test

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you!

Could you raise a separate PR to update the changelog for both 3.5 and. 3.4?

@henrybear327
Copy link
Contributor Author

LGTM

Thank you!

Could you raise a separate PR to update the changelog for both 3.5 and. 3.4?

Sorry @ahrtr , I forget about this... On it now!

I will add this to my checklist!

@ahrtr ahrtr merged commit 692c2d2 into etcd-io:release-3.5 Apr 18, 2024
25 checks passed
@henrybear327 henrybear327 deleted the backport-3.5/ignore-raft-messages-if-member-id-mismatch branch April 18, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants