Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server/etcdmain: eliminate deprecated tlsConfig.BuildNameToCertificate() #17787

Merged
merged 1 commit into from
Apr 17, 2024
Merged

server/etcdmain: eliminate deprecated tlsConfig.BuildNameToCertificate() #17787

merged 1 commit into from
Apr 17, 2024

Conversation

callthingsoff
Copy link
Contributor

As the doc is saying:

Deprecated: NameToCertificate only allows associating a single certificate
with a given name. Leave that field nil to let the library select the first
compatible chain from Certificates.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@callthingsoff
server/etcdmain: eliminate deprecated tlsConfig.BuildNameToCertificate()
ecb52d7 
As the doc is saying:

Deprecated: NameToCertificate only allows associating a single certificate
with a given name. Leave that field nil to let the library select the first
compatible chain from Certificates.

Signed-off-by: Jes Cok <[email protected]>
@k8s-ci-robot
Copy link

Hi @callthingsoff. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ivanvc
Copy link
Member

ivanvc commented Apr 13, 2024

This function was deprecated in Go 1.14. The solution is, indeed, removing the call to the function.

/ok-to-test

@jmhbnz
Copy link
Member

jmhbnz commented Apr 14, 2024

/retest

@callthingsoff
Copy link
Contributor Author

This function was deprecated in Go 1.14. The solution is, indeed, removing the call to the function.

Thanks, can you please approve it?

ivanvc
ivanvc approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@callthingsoff
Copy link
Contributor Author

Thanks, need another approval?

@serathius serathius merged commit e37a67e into etcd-io:main Apr 17, 2024
45 checks passed
@callthingsoff callthingsoff deleted the eliminate_tls.Config.NameToCertificate branch April 17, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

@serathius serathius serathius approved these changes

@ivanvc ivanvc ivanvc approved these changes

Assignees
No one assigned
Labels
ok-to-test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@callthingsoff @k8s-ci-robot @ivanvc @jmhbnz @serathius @ahrtr