-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5] Backport release script fixes #17732
Conversation
Signed-off-by: James Blair <[email protected]>
Signed-off-by: James Blair <[email protected]>
Signed-off-by: James Blair <[email protected]>
Skipping CI for Draft Pull Request. |
If you are trying to update the commit history to show file fork in code review, I can say I tried and it doesn't work on github. |
I was hoping github would show the file as renamed rather than just updated but I don't think it will work that way yeah. All good - ready for review now. cc additional attendees of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jmhbnz
This pull request:
release-3.5
to prevent issues with git remotes when the script attempts to push tags.release-3.5
to ensure all key etcd branchesrelease-3.4
,release-3.5
andmain
all use the same name for the release script which aligns with our release documentation.