Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Backport release script fixes #17732

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Apr 7, 2024

This pull request:

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@serathius
Copy link
Member

If you are trying to update the commit history to show file fork in code review, I can say I tried and it doesn't work on github.

@jmhbnz jmhbnz changed the title [3.5] WIP Backport release script fixes [3.5] Backport release script fixes Apr 8, 2024
@jmhbnz jmhbnz marked this pull request as ready for review April 8, 2024 10:58
@jmhbnz
Copy link
Member Author

jmhbnz commented Apr 8, 2024

If you are trying to update the commit history to show file fork in code review, I can say I tried and it doesn't work on github.

I was hoping github would show the file as renamed rather than just updated but I don't think it will work that way yeah.

All good - ready for review now.

cc additional attendees of 3.5.13 release call @ahrtr, @spzala

@ahrtr
Copy link
Member

ahrtr commented Apr 8, 2024

BTW, I think we should release 3.5.14 and 3.4.32 based on the release criteria. @jmhbnz @spzala

Will work together with @spzala to get 3.4.32 released.

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmhbnz

@ahrtr ahrtr merged commit 10e469e into etcd-io:release-3.5 Apr 8, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants